fix: document inherited COM interface methods#1715
Merged
jevansaks merged 1 commit intoJun 13, 2026
Conversation
Member
|
@nanookclaw thanks for the contribution! Looks good, but there is a merge conflict. Could you resolve and I can approve? |
c1ef703 to
c1807a5
Compare
Contributor
Author
|
Rebased on current Conflict resolution kept the docs fix ( Local verification:
|
jevansaks
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1391.
Inherited COM interface methods are re-emitted with
new, but their documentation lookup used the derived interface name. That made inheritedIShellDispatch2members such asFileRunsearch forIShellDispatch2.FileRun, even though the docs entry belongs to the declaring base interface,IShellDispatch.FileRun.This updates the COM interface generator to use the method metadata declaring interface only for inherited members while preserving the existing lookup key for methods declared directly on the generated interface. A focused regression test generates
IShellDispatch2, checks that inheritedFileRunis still emitted asnew void FileRun();, and verifies it receives the same XML docs asIShellDispatch.FileRun. The test also checks a directIShellDispatch2method still receives documentation.Verification
/tmp/dotnet-cswin32/dotnet test test/Microsoft.Windows.CsWin32.Tests/Microsoft.Windows.CsWin32.Tests.csproj --no-restore --filter FullyQualifiedName~COMTests.InheritedCOMInterfaceMethodsUseBaseMethodDocs