Enable COM runtime tests in CI PR gates#1734
Draft
jevansaks wants to merge 1 commit into
Draft
Conversation
Remove RequiresHardware trait from COM runtime tests that don't need GPU/D3D hardware. Only the ReturnValueMarshalsCorrectly tests (which create D2D render targets) retain the RequiresHardware exclusion. Tests that depend on Explorer shell or WMI namespaces that may not be available on headless CI VMs now gracefully skip via Assert.Skip when the required COM objects are unavailable, rather than being excluded entirely. This ensures PR gates exercise actual COM interop code paths through .NET runtime, not just verify that the generated code compiles. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jevansaks
force-pushed
the
user/jevansa/enable-com-runtime-tests
branch
from
b90ba0e to
4950ec6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable COM runtime tests in CI PR gates by removing the
RequiresHardwaretrait from tests that don't actually need GPU/D3D hardware.What changed
11 tests now run in CI (previously all 14 were excluded):
RemotableInterfaceCanCallIDispatchOnlyMethodsIWbemServices_GetObject_WorksCanCallINetFwMgrApisIShellItem_BindToHandler_IStream_ReadWorksIShellItem_BindToHandler_GenericOverloadSHCreateItemFromParsingName_GenericOverloadIWbemServices_GetObject_WorksCanCallINetFwMgrApisCanCallPnPAPIsIShellItem_BindToHandler_IStream_ReadWorks3 tests remain excluded (genuinely need GPU):
ReturnValueMarshalsCorrectlyReturnValueMarshalsCorrectlyReturnValueMarshalsCorrectlyWhy
The
RequiresHardwarefilter was blanket-excluding all COM runtime tests from CI. This meant PR gates only verified that generated code compiles but never exercised actual COM interop through .NET runtime. Tests that might fail on headless VMs (Shell, WMI) now useAssert.Skipfor graceful degradation instead of being excluded entirely.No CI workflow changes needed
The existing
test-fast-windowsjob filter (TestCategory!=HighMemory&TestCategory!=RequiresHardware) automatically picks up these tests now that the trait is removed.