Allow derivatives in coalescing nodes #7942
Open
+30
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the spec ( https://github.com/microsoft/DirectX-Specs/blob/master/d3d/WorkGraphs.md#quad-and-derivative-operation-semantics ) derivatives are allowed in all but thread launch nodes, but the validator disallowed them in coalescing nodes. This changes the validator to allow derivatives in coalescind nodes and adds testing for derivatives in coalescing and broadcast nodes. Fixes microsoft#7723
tools/clang/test/HLSLFileCheck/hlsl/objects/Texture/derivatives_in_csmsas.hlsl
Show resolved
Hide resolved
tools/clang/test/HLSLFileCheck/hlsl/objects/Texture/derivatives_in_csmsas.hlsl
Show resolved
Hide resolved
added mention of coalescing nodes allowing derivatives
Collaborator
|
LGTM! |
alsepkow
approved these changes
Dec 5, 2025
Contributor
alsepkow
left a comment
alsepkow
left a comment
There was a problem hiding this comment.
LGTUS (Me and Finn reviewed together).
But we were curious why inputData and inputRecords need to be declared as input arguments.
Collaborator
Author
I suppose they aren't. I guess I thought they were required. Removed. Could one of you trigger the CI checks? |
V-FEXrt
approved these changes
Dec 5, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the spec ( https://github.com/microsoft/DirectX-Specs/blob/master/d3d/WorkGraphs.md#quad-and-derivative-operation-semantics ) derivatives are allowed in all but thread launch nodes, but the validator disallowed them in coalescing nodes.
This changes the validator to allow derivatives in coalescind nodes and adds testing for derivatives in coalescing and broadcast nodes.
Fixes #7723