Fixing security issues flagged by CodeQL #7985
Open
+5
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
bob80905
approved these changes
Dec 5, 2025
inbelic
reviewed
Dec 6, 2025
| "otherwise the caller did not check"); | ||
| m_Mask = 0; | ||
| for (BYTE c = StartComp; c < StartComp + NumComp; c++) { | ||
| BYTE EndComp = StartComp + NumComp; |
There was a problem hiding this comment.
It seems weird to me that the change above is removing the BYTE type but not here?
Collaborator
Author
There was a problem hiding this comment.
In both scenarios, code ql complain is:
Comparisons between types of different widths in a loop condition can cause the loop to behave unexpectedly.
In this instance:
for (BYTE c = 0; c < SE.GetCols(); c++) {
BYTE Comp = SE.GetStartCol() + c;SE.GetCols() returns an unsigned int, and c only usage is in order to calculate Comp which only usage is at function: GetRegIndex, which if you check expects an unsigned int. Since all usages are of unsigned int, I found that it made sense to change the type to unsigned int.
Now, in this scenario:
for (BYTE c = StartComp; c < StartComp + NumComp; c++) {The issue is being cause because, StartComp + NumComp results in an int, while c is still a byte. Therefore, I found it easier to cast it back to BYTE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeQL found some issues within this repo, this patch fixes those issues following it's recommended approach