[MSVC] Fix a warning that is a default-error on modern MSVC#8488
Merged
bob80905 merged 2 commits intoMay 29, 2026
Conversation
bogner
approved these changes
May 29, 2026
hekota
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are warnings emitted:
that can be remedied by guarding the specialization against the MSVC STL version that forbids it.
This PR adds an extra condition (!(defined(_MSVC_STL_UPDATE) && _MSVC_STL_UPDATE >= 202604L)) to skip the std::is_nothrow_constructible specializations on MSVC STL releases that enforce N5014 [meta.rqmts]/4. This is more precise than checking _MSC_VER because the restriction comes from the STL headers, not the compiler itself. Newer STL versions compute the trait correctly without the workaround.
The build fails because /WX treats the warning as an error (C2220).
Assisted by: Github Copilot
Resolves #8449