PR 10 Commit A: AttentionBanner label + Settings focus ring + inline-alert z-index

[jschick04]

Polish on top of #553 stack: small fixes addressed across 3 cosmetic surfaces.

Changes

• AttentionBanner action text: Open Settings → Open Databases (and flipped IMenuActionService.OpenDatabaseToolsAsync() signature from Task → Task<bool> so MauiMenuActionService surfaces the previously-discarded bool)
• Settings ValueSelect :focus-visible rings no longer clipped (added .5rem padding on .settings-form > .flex-column-scroll)
• Inline-alert overlay paired z-index (overlay:2 + alert:3) above sticky save-strip (z-index:1)

Stack

This PR is the first of three stacked on top of #553. Order:

1. Settings UI restructure + DatabaseToolsModal extraction with per-row upgrade progress and modal-aware banner cycle #553 (foundation: IA + DatabaseToolsModal extraction)
2. This PR (polish — Commit A)
3. PR for Commits B+C+D (banners — closes Banner: chevron nav not working and Attention 'Open Settings' shows while Settings is already open #526)
4. PR for Commits E+F (database row UX — closes Settings: no per-row spinner when an import-triggered or queued upgrade runs #525)

Tests

• UI: 253 (existing AttentionBanner / BannerHost tests renamed)
• All green

[Copilot]

Pull request overview

This PR applies small UI polish changes on top of the Settings/DatabaseTools modal refactor stack by updating the Attention banner action/label, preventing clipped focus rings in Settings, and ensuring inline-alert overlays render above sticky footer content.

Changes:

• Update AttentionBanner action/message from “Open Settings” to “Open Databases”, and change IMenuActionService.OpenDatabaseToolsAsync() to return Task<bool> so callers can detect “not opened” outcomes.
• Add padding to the Settings scroll container so :focus-visible rings aren’t clipped.
• Set explicit z-index values for inline-alert overlay + alert to keep them above the sticky save-strip.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/Unit/EventLogExpert.UI.Tests/Banner/BannerHostTests.cs	Updates banner-host regression test expectations for the new “Databases” failure path.
tests/Unit/EventLogExpert.UI.Tests/Banner/AttentionBannerTests.cs	Renames/updates AttentionBanner tests to cover the new “Open Databases” action and error messaging.
src/EventLogExpert/Adapters/Menu/MauiMenuActionService.cs	Changes OpenDatabaseToolsAsync to return Task<bool> by forwarding WasOpened from modal coordination.
src/EventLogExpert.UI/Settings/SettingsModal.razor.css	Adds padding to the scrolling column to prevent focus-ring clipping.
src/EventLogExpert.UI/Modal/ModalChrome.razor.css	Adds z-index values to inline-alert overlay and alert to ensure correct stacking above sticky elements.
src/EventLogExpert.UI/Banner/AttentionBanner.razor.cs	Renames the click handler and routes the banner action to OpenDatabaseToolsAsync, with updated error reporting text.
src/EventLogExpert.UI/Banner/AttentionBanner.razor	Updates rendered banner text/button label and binds to the renamed handler.
src/EventLogExpert.Runtime/Menu/IMenuActionService.cs	Updates OpenDatabaseToolsAsync contract from Task to Task<bool>.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jschick04]

Stack collapsed back into #553 after panel-clean review. All commits from this branch are now part of #553's history (via rebase patch-id auto-skipping and direct cherry-pick equivalence). Closing as superseded — no code loss.