Open
Conversation
Author
Author
|
@microsoft-github-policy-service agree company="Pennsylvania State University" |
sonichi
reviewed
Dec 27, 2022
flaml/automl/automl.py
Outdated
| self._trained_estimator.params[self._trained_estimator.ITER_HP] | ||
| != self.best_config[self._trained_estimator.ITER_HP] | ||
| ): | ||
| logger.warning("early stopping happened") |
Contributor
There was a problem hiding this comment.
Check the code coverage. If not covered, add a test case. Also, change the warning message as it is ambiguous.
sonichi
reviewed
Dec 30, 2022
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
sonichi
reviewed
Jan 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
It is because that the corresponding correct error and warning information are very useful.
Related issue number
#804
#800
Checks