Skip to content

feat: add lock icon for private agents and devices (fixes #345) - #719

Open
Nagachandan P (NagachandanP) wants to merge 1 commit into
microsoft:mainfrom
NagachandanP:fix/issue-345-private-device-agent-icon
Open

feat: add lock icon for private agents and devices (fixes #345)#719
Nagachandan P (NagachandanP) wants to merge 1 commit into
microsoft:mainfrom
NagachandanP:fix/issue-345-private-device-agent-icon

Conversation

@NagachandanP

@NagachandanP Nagachandan P (NagachandanP) commented Jul 7, 2026

Copy link
Copy Markdown

fixes #345

Add lock icon for private agents and devices (fixes #345)

Description

Adds a yellow lock icon and explanatory tooltip for private agents and private devices on the Connected Devices page.

  • Private agent: indicated when an agent.teamId exists (shows lock + tooltip Private — Team: <teamName>).
  • Private device: indicated when item.isPrivate is true (shows lock + tooltip Private device).

Linked GitHub issue ID: #345

Pull Request Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Code compiles correctly with all tests passed (manual smoke; unit tests not included in this PR)
  • I've read the contributing guide and followed recommended practices for UI changes
  • Wikis / README updated if needed

Does this introduce a breaking change?

  • Yes
  • No

How you tested it

  • Manual visual verification: dev server (webpack) — lock appears next to private items and tooltip shows expected text.
  • A unit test was created during development to verify the device lock icon rendering, but test infra was intentionally removed from this minimal PR per contributor request. If you want tests included, I can add them in a follow-up or separate PR.
  • Screenshot
yellow-lock

Type of change: Feature


If you need help or want tests included, open an issue: https://github.com/microsoft/HydraLab/issues/new

@jianyuyouyin

jianyuyouyin commented Jul 7, 2026 via email

Copy link
Copy Markdown

@NagachandanP

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@NagachandanP
Nagachandan P (NagachandanP) force-pushed the fix/issue-345-private-device-agent-icon branch from 06f0734 to 9a29343 Compare August 29, 2026 12:44
@NagachandanP

Copy link
Copy Markdown
Author

Updated the commit email to match my GitHub account and signed the CLA. Could someone please approve the CI workflow run? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Could Hydra Lab add an icon aside the private device/agent?

3 participants