Repository navigation
FIX: apply font_color to PDFs PDFConverter generates - #3136
Merged
Roman Lutz (romanlutz) merged 4 commits intoOct 14, 2026
Merged
Conversation
Roman Lutz (romanlutz)
approved these changes
Oct 14, 2026
Roman Lutz (romanlutz)
enabled auto-merge
October 14, 2026 04:21
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3105.
Went with the option that doesn't change anything for people who don't pass a color:
font_colornow defaults toNone.font_color, or black when it isn't set (same as today), and set it again after each page break.font_colorisn't set, so hidden injected text keeps working. Iffont_coloris set, they use it.font_coloris in the identifier when set. Unset is dropped, so default PDFConverter hashes don't move. I leftrow_height/column_width/injection_itemsout to keep this small.Tests go through
convert_asyncand read the fill-color ops back out of the PDF content stream:The new ones fail on main. tests/unit/converter, registry and backend/test_converter_service: 2928 passed.