FIX: use the canonical score-to-outcome mapping when a human score is removed

pyrit/backend/services/attack_service.py

@@ -68,6 +68,7 @@
 )
 from pyrit.backend.services.target_service import get_target_service
 from pyrit.common.utils import to_sha256
+from pyrit.executor.attack import attack_outcome_from_score
 from pyrit.memory import (
     AttackResultKeysetCursor,
     CentralMemory,
@@ -867,13 +868,13 @@ async def remove_human_score_async(self, *, attack_result_id: str) -> AttackSumm
             return None
 
         automated_score = results[0].automated_score
-        if automated_score is None or automated_score.score_value is None:
-            outcome = AttackOutcome.UNDETERMINED
+        # Follow the attack-side contract of attack_outcome_from_score (#3181): read the
+        # typed score value instead of comparing the raw string, and treat an undetermined
+        # score as neither achievement nor refutation.
+        outcome = AttackOutcome.UNDETERMINED if automated_score is None else attack_outcome_from_score(automated_score)
+        if outcome is AttackOutcome.UNDETERMINED or automated_score is None:
             outcome_reason = None
         else:
-            outcome = (
-                AttackOutcome.SUCCESS if automated_score.score_value.casefold() == "true" else AttackOutcome.FAILURE
-            )
             outcome_reason = automated_score.score_rationale
 
         await self._memory.update_attack_result_by_id_async(

tests/unit/backend/test_attack_service.py

@@ -3410,3 +3410,57 @@ def test_create_attack_request_normalizes_legacy_attribution_labels() -> None:
 def test_create_attack_request_rejects_overlength_values() -> None:
     with pytest.raises(ValueError, match="at most 128"):
         CreateAttackRequest(target_registry_name="target", operator="x" * 129)
+
+
+class TestRemoveHumanScoreOutcomeByScoreType:
+    """Removing a human score must follow the canonical score-to-outcome contract (#3181)."""
+
+    @pytest.mark.parametrize(
+        ("score_type", "score_value", "expected_outcome"),
+        [
+            ("float_scale", "0.9", "success"),
+            ("float_scale", "0.0", "failure"),
+            ("true_false", "True", "success"),
+            ("true_false", "False", "failure"),
+        ],
+    )
+    async def test_remove_human_score_maps_typed_score_values(
+        self,
+        attack_service,
+        mock_memory,
+        score_type: str,
+        score_value: str,
+        expected_outcome: str,
+    ) -> None:
+        attack = make_attack_result(conversation_id="test-id")
+        attack.automated_score = Score(
+            score_type=score_type,
+            score_value=score_value,
+            score_rationale="Automated rationale",
+        )
+        mock_memory.get_attack_results_async.return_value = [attack]
+
+        await attack_service.remove_human_score_async(attack_result_id="ar-test-id")
+
+        update_fields = mock_memory.update_attack_result_by_id_async.call_args.kwargs["update_fields"]
+        assert update_fields["outcome"] == expected_outcome
+
+    async def test_remove_human_score_with_undetermined_automated_score_is_undetermined(
+        self,
+        attack_service,
+        mock_memory,
+    ) -> None:
+        attack = make_attack_result(conversation_id="test-id")
+        attack.automated_score = Score(
+            score_type="true_false",
+            score_value=None,
+            score_rationale="No verdict",
+            status="undetermined",
+        )
+        mock_memory.get_attack_results_async.return_value = [attack]
+
+        await attack_service.remove_human_score_async(attack_result_id="ar-test-id")
+
+        update_fields = mock_memory.update_attack_result_by_id_async.call_args.kwargs["update_fields"]
+        assert update_fields["outcome"] == "undetermined"
+        assert update_fields["outcome_reason"] is None