Repository navigation
MAINT Extract message view model from MessageList - #3198
Merged
Roman Lutz (romanlutz) merged 3 commits intoOct 15, 2026
Merged
Conversation
Contributor
|
Thanks for the contribution Isaac Emmanuel (@1cbyc) ! We've had a lot of cases recently where the CLA wasn't accepted and authors never responded after the initial PR push. If I don't hear back by 10/17 I'll close this PR because we need the CLA. See posts by @microsoft-github-policy-service above. |
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
Author
|
Roman Lutz (@romanlutz) kindly check again. |
Roman Lutz (romanlutz)
approved these changes
Oct 14, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs #2654.
MessageListcurrently owns pure message-shaping rules alongside its React rendering. This extracts the first requested boundary into a typedmessageViewModelmodule:MessageListremains responsible for list rendering, loading/empty states, and scrolling. This is intentionally a focused first slice of the issue; it does not change user-visible behavior or attempt the separate media, score, and action component boundaries.Tests and Documentation
npm test -- --runInBand src/components/Chat/messageViewModel.test.ts src/components/Chat/MessageList.test.tsx(67 passed)npm run type-checknpx eslint src/components/Chat/MessageList.tsx src/components/Chat/messageViewModel.ts src/components/Chat/messageViewModel.test.ts --max-warnings 0Added focused tests for structured-content formatting, explicit display-piece identity/order, and legacy content/attachment score separation. No documentation changes are needed because this is an internal refactor with unchanged behavior.