-
Notifications
You must be signed in to change notification settings - Fork 339
AimTTiQL355TP over voltage and over current protection support #5156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add support for over voltage protection
Add trip_reset function
for more information, see https://pre-commit.ci
missing return
missing type declaration
|
@AdamVerner please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
|
@AdamVerner would you be able to resovle merge conflicts? then we can merge this PR |
|
|
||
| super().__init__(name, address, **kwargs) | ||
|
|
||
| for channel in [self.ch1, self.ch2]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make it more reusable, use the
for i in range(1, self.numOfChannels + 1):
channel = AimTTiChannel(self, f"ch{i}", i)Instead of fixed channels (See _AimTTI_PL_P.py line 275-276)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AdamVerner Are you still interested in this work?
@huisman2501 would you be able to create a new pr that takes over this work otherwise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am currently working on AIM PSUs and have some more properties that I can add. They seem to be more generic among models. I will see what I can do (I have a MX100TP and CPX400DP to test with)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's been more than 2 years now, I work in completly different field now. Feel free to take it over from me 😄
I have previously added a driver for this device, but it is missing over voltage protection.
This PR adds the parameter for OVP and also trip_reset