Make command caller get/set_raw a method #5724
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jenshnielsen
force-pushed
the
command_caller_to_method
branch
from
67de88a to
fff34e8
Compare
jenshnielsen
force-pushed
the
command_caller_to_method
branch
2 times, most recently
from
5b0ccfe to
c7fb39c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5724 +/- ##
==========================================
+ Coverage 69.33% 69.36% +0.02%
==========================================
Files 340 340
Lines 31261 31290 +29
==========================================
+ Hits 21676 21703 +27
- Misses 9585 9587 +2 ☔ View full report in Codecov by Sentry. |
jenshnielsen
force-pushed
the
command_caller_to_method
branch
4 times, most recently
from
8eef902 to
bb8f6ae
Compare
jenshnielsen
force-pushed
the
command_caller_to_method
branch
from
bb8f6ae to
8b6fca4
Compare
jenshnielsen
force-pushed
the
command_caller_to_method
branch
from
8b6fca4 to
913c886
Compare
jenshnielsen
force-pushed
the
command_caller_to_method
branch
from
dc159ac to
c9fee6d
Compare
jenshnielsen
force-pushed
the
command_caller_to_method
branch
from
632b84a to
5a8f53c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes get/set_raw proper methods rather than callable attributes and furthermore extracts the logic of generating the get/set_raw code into a factory function for added clarity.