Repository navigation
Mitigate PHP vulnerability and add ACR BuildKit tasks - #3208
Merged
Merged
Conversation
robgruen
enabled auto-merge
October 21, 2026 21:57
George Ng (GeorgeNgMsft)
approved these changes
Oct 21, 2026
George Ng (GeorgeNgMsft)
left a comment
Contributor
There was a problem hiding this comment.
Approving to unblock, but there are two critical concerns to address.
Co-authored-by: robgruen <25374553+robgruen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Docker build and deployment process for the TypeAgent project, focusing on improved security, reproducibility, and maintainability. The main changes include switching to BuildKit-enabled builds in Azure Container Registry (ACR), modernizing and securing the Dockerfile, expanding
.dockerignorefor cleaner builds, and updating documentation to reflect the new process.Build pipeline and ACR integration:
azure-build-docker-container.yml) now usesaz acr runwith BuildKit and a newacr-build.yamltask definition, replacing the previousaz acr buildapproach. This enables secret mounts and a more flexible build process. [1] [2] [3] [4]Dockerfile modernization and security:
Dockerfileis updated to use Node 24 on Debian Bookworm, install dependencies more securely (including Azure CLI 2.91.0), and leverage BuildKit secrets for npm registry credentials. The build steps now use explicit secret mounts, and the container starts the API server directly with Node, removing the need for npm registry access at runtime. [1] [2] [3] [4] [5]Build context and reproducibility:
.dockerignorefile is expanded to exclude allnode_modules, build outputs, environment files, and local configuration, ensuring a cleaner and more reproducible build context.Documentation updates:
README.mdis updated with detailed instructions for building the Docker image locally and via the new ACR pipeline, including guidance on using private npm registries and BuildKit secrets.New ACR build task:
acr-build.yamlfile defines the ACR BuildKit build and push steps, parameterized for image name and tag.