Repository navigation
Reduce macOS CI latency while preserving platform coverage - #3213
Merged
Merged
Conversation
Keep representative macOS correctness checks blocking and run full macOS coverage nightly. Preserve independent script-test accounting, retry failed Jest files safely, canonicalize generated-file paths, and move history scaling to periodic regressions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Extract individual package retries without changing failure classification or test phase accounting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hillary Mutisya (hillary-mutisya)
marked this pull request as ready for review
October 23, 2026 21:32
Dominic Nguyen (datduyng)
approved these changes
Oct 23, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change
macOS test jobs have been holding up PR validation for more than an hour, often after the corresponding Ubuntu and Windows jobs have finished. We reviewed five recent completed PRs to separate slow initial execution from time spent retrying failures.
The table shows median Test-step duration in minutes, including retries, across each PR's configured Node versions. It does not include installation or build time.
This sample contains 36 executed test jobs. Some PRs had two Node versions rather than three. Two other recent PRs never reached testing and were excluded from the retry denominators. These are historical observations, not a controlled benchmark.
Both initial execution and retries are expensive:
Removing a few scaling tests would not address these delays. This PR keeps a smaller macOS compatibility suite blocking changes, moves full macOS coverage to nightly runs, and reduces unnecessary retry work.
Changes
Split blocking and nightly macOS coverage.
Retry failed files where the runner supports it.
Fix test-phase accounting.
Apply consistent Jest settings.
Fix macOS aliased-path handling in generated-file healing.
/varto/private/var.Separate memory correctness from scaling coverage.
Coverage tradeoff
The blocking macOS selection is intentionally not the full correctness suite. Full Ubuntu/Windows coverage still blocks PRs, but macOS-only regressions outside the selection may first appear nightly. Maintainers should triage nightly failures and add missing platform-sensitive regressions to the blocking selection. Contract tests check the explicit selection and event-specific workflow configuration.
This PR does not claim a measured macOS speedup yet. It also does not fix the separately identified MCP shutdown test that waits for the client's 60-second timeout.
Validation