Skip to content

Fix managed Copilot runtime discovery and startup validation - #3215

Open
George Ng (GeorgeNgMsft) wants to merge 1 commit into
mainfrom
fix/managed-copilot-runtime-discovery
Open

George Ng (GeorgeNgMsft) wants to merge 1 commit into
mainfrom
fix/managed-copilot-runtime-discovery

Conversation

@GeorgeNgMsft

@GeorgeNgMsft George Ng (GeorgeNgMsft) commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Keep TYPEAGENT_RUNTIME_ROOT for bundled application assets, not the Copilot cache. Preserve the dedicated cache environment variable, platform defaults, and --runtime-root override.

Share executable selection between the model and reasoning clients. Honor TYPEAGENT_COPILOT_CLI_PATH before COPILOT_CLI_PATH, while keeping explicit client paths and the credit-budget evaluation override ahead of both. Credit handling, isolated configuration, and permission handling are unchanged.

Runtime-only setup now starts the selected runtime, checks SDK status, and stops the client before reporting success. It does not query authentication or models. Startup failures flow through the MSI's existing incomplete-setup warning path without rolling back installation; normal setup still requires sign-in.

Validation

Built agent-dispatcher and its dependencies successfully. All 114 targeted tests passed:

  • 38 managed-runtime, pruning, and MSI integration tests, including a freshly bundled helper with separate application/cache directories and simulated SDK startup failures.
  • 34 aiclient transport tests.
  • 36 reasoning credit-budget, permission, and tool tests.
  • 6 reasoning client-construction tests covering runtime precedence and the evaluation override with and without a credit budget.

Prettier and the lint, complexity, circular-dependency, and code-debt ratchets passed. Completed a direct adversarial review with no outstanding findings.

Also ran the updated helper against a real cached Copilot 1.0.83 runtime with the application-root environment variable set and no dedicated cache override. Default lookup succeeded, followed by:

GitHub Copilot runtime startup verified.

A clean MSI installation and end-to-end macro recording/replay were not run. The automated bundled-layout tests use an SDK test double; the separate local startup check used the real SDK and runtime.

Keep application assets separate from the runtime cache, share configured executable selection with reasoning, and verify SDK startup during runtime-only setup without requiring login.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0040b8ff-2701-4fb7-821f-760e05fe6b4b
@GeorgeNgMsft
George Ng (GeorgeNgMsft) added this pull request to the merge queue Oct 25, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 25, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants