Repository navigation
Add indexed topic curation, Decision-assisted admission, and frozen replay - #3233
Merged
Hillary Mutisya (hillary-mutisya) merged 8 commits intoOct 27, 2026
Merged
Hillary Mutisya (hillary-mutisya) merged 8 commits into
Hillary Mutisya (hillary-mutisya) merged 8 commits into
Conversation
Preserve default packing and serial commits while adding complete-request inspection, opt-in prior allocation and freshness-checked speculation. Keep exact evidence validation and durable checkpoints; document measured limits. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Integrate native feature feede39 and shared infrastructure d082947 on the current memory28 tree without replaying squashed history. Use one validated named-mode generator API and a delta-only shared lexical index with transaction-owned native positions. Preserve generative defaults and add both-engine replay, protocol and incremental replacement regressions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Validate named generator modes, migrate dynamic callers, remove shared ordinal ownership, cover constant-delta catalog visits and large replay identity patches, and make retry timing tests independent of body stream I/O. Correct the frozen workspace dependency link and document the canonical contracts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Validate complete source incidence before selecting replay nodes, then validate checkpoint membership against the selected subset. Cover partial and completed restart, selection mismatch, and evidence outside the selected nodes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Exclude unrelated automatic maintenance from history and projection read counts using the existing async operation context. Exercise concurrent unrelated reads while retaining exact one-projection and zero-full-history assertions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pin retry jitter to its maximum and verify the exact Retry-After plus jitter boundary. Restore timers and mocks after every test so a timed-out fake-clock test cannot stall subsequent credential timeout and cancellation tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hillary Mutisya (hillary-mutisya)
added a commit
that referenced
this pull request
Oct 28, 2026
## Summary Make Memory Hub responsive and consistent when browsing populated long-conversation memory collections. - Fix agent RPC callback ownership so nested execution contexts do not leave requests waiting indefinitely. - Return compact question/view inventories and conflict summaries; defer evidence/detail fetches and preserve bounded pagination. - Simplify entity/topic graph pages, trim unused graph payloads, and use compact Font Awesome graph controls. - Organize Inbox attention into counted categories with bounded previews and detail panels; align tabs, list cards, totals, loading indicators, pagination, and accessible icon actions across destinations. - Add option B synopsis/metadata sidecards to Knowledge Wiki and Project Brief readers, with compact icon toolbars and overflow menus. - Add dedicated corpus/view/slot question routes, a responsive two-column inventory, full-page question readers with metadata sidecards, and guarded Back/history/edit behavior. Remove the duplicate Questions tab from Views. - Exclude question/schema views from Views gallery queries before pagination and totals, without changing dedicated Questions or exact schema-view readers. - Use consistent review, list, build-status, and maintenance icons. This PR contains the focused Memory Hub follow-up work. The previous integration work from #3233 is already in main and is not resubmitted. ## Validation - Full TypeScript workspace build passes on Node 24.22.1 with pnpm, using installed dependencies and a process-local `verifyDepsBeforeRun=false` override to avoid an unrelated package-feed auto-install. - **603 targeted tests pass:** 424 browser-client tests, 117 browser-gateway tests, 49 schema-view/inventory-concurrency tests, 5 RPC-context tests, and 8 protocol tests. These cover question routes, off-page direct loads, Back/history, unsaved edits, loading/error/retry races, sidecards, graph payloads, optimistic concurrency, retained-panel focus, direct/post-edit/repeated discovery, and gallery filtering/pagination. - Pinned Prettier passes for the PR files. Lint, complexity, circular-dependency and debt ratchets pass against current main on the committed PR diff. - Live populated-store checks passed at desktop/tablet/mobile widths (1440 through 390px), with no application exceptions or failed RPC responses. - Direct question reload verified one exact question request plus one corpus/view summary request with page size 1, without scanning other collections. - Latest live populated-store query check: 42 unfiltered views include 5 schema views; the gallery query returns exactly 37 non-question views. Explicit schema lookup still returns one view, and the dedicated Questions inventory retains all 5 questions. Existing source evidence, question review/assertion/discovery behavior, publication/edit safeguards, and maintenance warnings remain intact. ## Review follow-up Addressed all six initial Copilot review threads in 741a986 and 667d6ab: - Replace stale question controls before every slot load and on failure. - Refresh reader-specific edit heads independently of the inventory scope; verify two successive cross-collection edits. - Reject navigation during pending question operations. - Preserve unsaved drafts without confirmation dialogs during background polling. - Preserve unchanged Inbox details across count refreshes using stable identities and state fingerprints. - Restore keyboard/screen-reader graph selection with an on-demand native item picker using the already-loaded graph, without restoring graph-page clutter or extra inventory requests. The follow-up passes all 43 client suites (419 tests), client type-checking, pinned formatting and all four PR ratchets. Live checks verified draft retention across a real 65-second polling interval, stale-editor removal after a forced detail failure, and keyboard-only evidence inspection on both graph types. Addressed both subsequent review threads in ae2993d: - Retained Inbox panels update their return-focus target when Review buttons are reconstructed. - Reader discovery shares the selected-reader head guard with edits and refreshes exact reader metadata before subsequent mutations. Also addressed the gallery follow-up: every gallery summary query carries `excludeKinds: ["schemaView"]`, including pagination. Filtering is performed by the service before totals and cursors are calculated. Default inventory queries and explicit schema-view reads preserve their previous behavior. The latest client suite passes 424 tests. The current-head Copilot re-review published a nonempty summary with no new unresolved threads. CI for ae2993d is complete: all reported checks pass or are intentionally skipped. The isolated Ubuntu/Node 24.22.1 webpack-loading failure passed on a failed-job-only retry; no source changes were needed. Windows/Linux smoke tests and the full build matrix pass. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds indexed topic curation, an opt-in Decision-assisted curation engine, and reproducible evaluation from saved inputs. Both engines use the same generator API, evidence/ownership indexes, request inspection, validation, and replay utilities.
Functionality
Shared curation and model infrastructure
raw,generative, ordecisionmode. Migrate service hosts, tools, and tests; reject malformed modes and incompatible engine settings.Generative curation
Decision-assisted curation
Generative curation remains the service default, with legacy packing, one worker, and lazy summaries. Token-aware packing, generative speculation, and Decision curation are explicit options.
Frozen replay and evaluation
Review guide
Validation
pnpm run build.pnpm run test:memory-quality: 169 tests.