Skip to content

Remove StyleMedia - #2199

Merged
github-actions[bot] merged 2 commits into
microsoft:mainfrom
Bashamega:remove-react
Jan 8, 2026
Merged

Remove StyleMedia#2199
github-actions[bot] merged 2 commits into
microsoft:mainfrom
Bashamega:remove-react

Conversation

@Bashamega

Copy link
Copy Markdown
Contributor

Can you test this Jake Bailey (@jakebailey) ?
Sorry for the late PR, I was busy

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the PR!

This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged.

@saschanaz

Copy link
Copy Markdown
Contributor

This is removing StyleMedia not StylePropertyMap, please change the title

@jakebailey Jake Bailey (jakebailey) changed the title Remove StylePropertyMap Remove StyleMedia Oct 20, 2025
@jakebailey

Copy link
Copy Markdown
Member

React v15 is still using this, it seems. Probably not worth removing?

@saschanaz

Copy link
Copy Markdown
Contributor

Yeah, we should try adding it to DT and maybe revisit this later

@Bashamega

Copy link
Copy Markdown
Contributor Author

Can you try to test this since the definitely typed PR was merged? Jake Bailey (@jakebailey)

@jakebailey

Copy link
Copy Markdown
Member

microsoft/TypeScript#62640 is happy on DT, but causes very odd test failures elsewhere that I need to investigate.

@Bashamega

Copy link
Copy Markdown
Contributor Author

Hello Jake Bailey (@jakebailey)
Did you have time to see why it was failing?

@saschanaz

Copy link
Copy Markdown
Contributor

I think we just are waiting for some time for people to adopt the DT side change

@jakebailey

Copy link
Copy Markdown
Member

DefinitelyTyped/DefinitelyTyped#73939 was merged a while ago, we can pretty easily tell people to update their types (there are worse breaks coming).

@Bashamega

Copy link
Copy Markdown
Contributor Author

DefinitelyTyped/DefinitelyTyped#73939 was merged a while ago, we can pretty easily tell people to update their types (there are worse breaks coming).

I have resolved the conflicts, merge it when you are ready

@saschanaz

Copy link
Copy Markdown
Contributor

LGTM

@github-actions
github-actions Bot merged commit 227aa3f into microsoft:main Jan 8, 2026
6 checks passed
@github-actions

github-actions Bot commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

Merging because Kagami Sascha Rosylight (@saschanaz) is a code-owner of all the changes - thanks!

@saschanaz

Copy link
Copy Markdown
Contributor

(there are worse breaks coming).

Should I be freaking out now?!

@jakebailey

Copy link
Copy Markdown
Member

Hah, no, I just mean there are other changes already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants