Migrate HTMLInputElement - #2338
Conversation
|
Thanks for the PR! This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged. |
| "overrideType": "AutoFillBase | `${OptionalPrefixToken<AutoFillSection>}${OptionalPrefixToken<AutoFillAddressKind>}${AutoFillField}${OptionalPostfixToken<AutoFillCredentialField>}`" | ||
| }, | ||
| { | ||
| "name": "Directions", |
There was a problem hiding this comment.
Do we have a plan to remove that again?
There was a problem hiding this comment.
For now, let's keep it in the JSON until we migrate because we still don't have support for type defs in KDL
There was a problem hiding this comment.
- Maybe something like SelectionDirection to prevent future conflict.
- Maybe do the KDL work first to prevent back and forth?
|
Can you say maybe HTMLInputElement or something to be more clear for the title? |
|
Done |
| name, | ||
| ...optionalMember("type", "string", node.properties?.type), | ||
| ...optionalMember("overrideType", "string", node.properties?.overrideType), | ||
| ...optionalMember("nullable", "boolean", node.properties?.nullable), |
There was a problem hiding this comment.
This is part of Typed and that should be handled by type node.
Added comments to clarify nullable types in setSelectionRange method.
| } | ||
| } | ||
| property autocomplete type=AutoFill | ||
| property valueAsDate type=Date |
There was a problem hiding this comment.
I'm not sure this should be allowed, Date is not an IDL type. But maybe not worth disallowing it... Let's see.
|
LGTM |
|
Merging because Kagami Sascha Rosylight (@saschanaz) is a code-owner of all the changes - thanks! |
3 participants
No description provided.