Skip to content

Support typedef in KDL - #2340

Merged
github-actions[bot] merged 6 commits into
microsoft:mainfrom
Bashamega:type-def
Dec 30, 2025
Merged

Support typedef in KDL#2340
github-actions[bot] merged 6 commits into
microsoft:mainfrom
Bashamega:type-def

Conversation

@Bashamega

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the PR!

This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged.

@saschanaz

Copy link
Copy Markdown
Contributor

Let's call it typedef as that's how it's called in multiple languages. Not sure how it end up as TypeDef in types.

@saschanaz

Copy link
Copy Markdown
Contributor

And also the title should change, I was confused

@Bashamega Adam Naji (Bashamega) changed the title Support types in KDL Support types definitions in KDL Dec 29, 2025
@Bashamega

Copy link
Copy Markdown
Contributor Author

I have renamed it Kagami Sascha Rosylight (@saschanaz)

@saschanaz

Copy link
Copy Markdown
Contributor

Let's say typedef?

@Bashamega

Copy link
Copy Markdown
Contributor Author

I don't understand. It was already typedef, and you requested it to be changed, or is there something that I am missing?

@HolgerJeromin

Copy link
Copy Markdown
Contributor

I don't understand. It was already typedef, and you requested it to be changed, or is there something that I am missing?

perhaps the PR title?

@Bashamega Adam Naji (Bashamega) changed the title Support types definitions in KDL Support typedef in KDL Dec 30, 2025
@saschanaz

Copy link
Copy Markdown
Contributor

LGTM

@github-actions
github-actions Bot merged commit 5535d0a into microsoft:main Dec 30, 2025
5 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Merging because Kagami Sascha Rosylight (@saschanaz) is a code-owner of all the changes - thanks!

@Bashamega
Adam Naji (Bashamega) deleted the type-def branch December 30, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants