Add linguist support for KDL and jsonc files - #2350
Conversation
|
Not sure we want to do that. mdn/content is almost 100% about markdown but this repo is about generating types and that's very typescript. We use KDL, sure, but to augment. |
The KDL files are no generated part, but written by hand. So IMO it would be nice to have that detected.
to the far more correct
|
|
I agree with Holger Jeromin (@HolgerJeromin) |
Kagami Sascha Rosylight (saschanaz)
left a comment
Kagami Sascha Rosylight (saschanaz)
left a comment
There was a problem hiding this comment.
This should include .jsonc too then. But doing so would make it like 90% jsonc/kdl. Do we want that? I don't know...
| ############################################################################### | ||
| # linguist support for kdl | ||
| ############################################################################### | ||
| *.kdl linguist-detectable=true |
There was a problem hiding this comment.
https://github.com/github-linguist/linguist/blob/a7e40d31e271f6747fa1234df37b5fff3e6e2406/docs/overrides.md#detectable doesn't use =true 🤔, so maybe skip it?
| # linguist support for kdl | ||
| ############################################################################### | ||
| *.kdl linguist-detectable=true | ||
| *.kdl linguist-language=KDL |
There was a problem hiding this comment.
Do we need to manually give language at all? This exists to reclassify the language, but the default classification should just work.
Which would be the truth.
Why not? |
|
I have updated it.
Maybe not since we are currently in the progress of removing them |
Because it's not code but augmentations? (I mean, data instead of code)
Which still has far way to go, and those are also handwritten so IMO either include both or neither |
Adam Naji (Bashamega)
changed the title
|
JSONC and Typescript are competing LOL JSON 42.1% |
|
Good change |
|
(This needs maintainer permission to merge) |
Jake Bailey (jakebailey)
left a comment
Jake Bailey (jakebailey)
left a comment
There was a problem hiding this comment.
It's weird that GitHub needs this hint but, alrighty
5 participants
This adds KDL to the list of languages. Check https://github.com/bashamega/TypeScript-DOM-lib-generator
Got this idea from mdn/content#14123