Fix: Playground errors when serializing logs#3168
Closed
lukaw3d wants to merge 1 commit intomicrosoft:v2from
Closed
Fix: Playground errors when serializing logs#3168lukaw3d wants to merge 1 commit intomicrosoft:v2from
lukaw3d wants to merge 1 commit intomicrosoft:v2from
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3169
Errors thrown in Playground's output serialization should be different than user code errors.
Before:
https://www.typescriptlang.org/play/?target=7#code/PTAEAEBcEMCcHMCmkBcoCiBlATABjwFADGA9gHYDOJANogHTUnwAUA3qNGgIw+9-8DBQ4ULKgAvgEoCQA
Click "Run"
thrown by
TypeScript-Website/packages/playground/src/sidebar/runtime.ts
Line 224 in c341935
After:
For comparison, user code error: