lib: fix misleading maxLength param on string pad* methods#63504
Open
youngspe wants to merge 2 commits into
Open
lib: fix misleading maxLength param on string pad* methods#63504youngspe wants to merge 2 commits into
maxLength param on string pad* methods#63504youngspe wants to merge 2 commits into
Conversation
typescript-bot
added
the
For Uncommitted Bug
This comment was marked as resolved.
This comment was marked as resolved.
RyanCavanaugh
requested changes
May 26, 2026
| * Pads the current string with a given string (possibly repeated) so that the resulting string reaches a given length. | ||
| * The padding is applied from the start (left) of the current string. | ||
| * Pads this string with a given string (repeated and/or truncated, if needed) so that the resulting string has a given length. | ||
| * The padding is applied from the start of this string. |
Member
There was a problem hiding this comment.
"this string" is ambiguous in this phrasing - it could refer to the string invoked on, or the string passed in as padding
github-project-automation
Bot
moved this from Not started
to Waiting on author
in PR Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63503
maxLengthparameter forString.padStartandString.padEndtotargetLength, which matches the MDN documentation.Note: As of the time the PR was created, the related issue has not been triaged. Please let me know if I didn't follow the right procedure here.