fix(62179): report non-string-literal values in import type attributes - #64099
Merged
Conversation
Copilot started reviewing on behalf of
Oleksandr Tarasiuk (a-tarasyuk)
August 30, 2026 17:11
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds grammar validation for non-string import type attributes.
Changes:
- Reuses import-attribute value validation for import types.
- Adds conformance coverage and diagnostic baselines.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tsc/internal/checker/checker.go |
Applies shared validation to import types. |
tsc/internal/checker/grammarchecks.go |
Extracts attribute-value validation. |
tsc/testdata/tests/cases/conformance/importAttributes/importAttributes12.ts |
Tests valid and invalid values. |
tsc/testdata/baselines/reference/conformance/importAttributes12.errors.txt |
Records expected diagnostics. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Jake Bailey (jakebailey)
approved these changes
Sep 1, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 1, 2026
Member
|
Seems like this needs a merge from main. |
Jake Bailey (jakebailey)
approved these changes
Sep 1, 2026
Jake Bailey (jakebailey)
enabled auto-merge
September 1, 2026 18:28
auto-merge was automatically disabled
September 1, 2026 19:18
Head branch was pushed to by a user without write access
Oleksandr Tarasiuk (a-tarasyuk)
requested a review
from Jake Bailey (jakebailey)
September 1, 2026 19:33
Jake Bailey (jakebailey)
enabled auto-merge
September 1, 2026 19:43
Jake Bailey (jakebailey)
approved these changes
Sep 1, 2026
Jake Bailey (jakebailey)
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62179