Keep instantiation expression symbols distinct and stable - #64123
Merged
Jake Bailey (jakebailey) merged 1 commit intoSep 1, 2026
Merged
Conversation
typescript-automation
Bot
added
For Uncommitted Bug
Copilot started reviewing on behalf of
Mateusz Burzyński (Andarist)
September 1, 2026 17:05
View session
Contributor
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
Comment on lines
+445
to
+446
| if t1.symbol != nil && len(t1.symbol.Declarations) != 0 { | ||
| declaration1 = t1.symbol.Declarations[0] |
There was a problem hiding this comment.
Is Declarations stable between every type-checker?
There was a problem hiding this comment.
Yes, that should be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #64116 (a regression from microsoft/typescript-go#4687 )