Fix completions inside tuple types suggesting value symbols

tsc/internal/fourslash/tests/completionsInEmptyTupleType_test.go

@@ -0,0 +1,54 @@
+package fourslash_test
+
+import (
+	"testing"
+
+	"github.com/microsoft/TypeScript/tsc/internal/fourslash"
+	. "github.com/microsoft/TypeScript/tsc/internal/fourslash/tests/util"
+	"github.com/microsoft/TypeScript/tsc/internal/testutil"
+)
+
+func TestCompletionsInEmptyTupleType(t *testing.T) {
+	t.Parallel()
+	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
+	const content = `type UserTuple = [["name", string], ["age", number], ["address", string]];
+type AdminTuple = [/*1*/];
+type OtherTuple = [string, /*2*/];
+type QueryTuple = [typeof /*3*/];
+
+const User: UserTuple = [["name", "2333"], ["age", 2333], ["address", "2333"]];`
+	f, done := fourslash.NewFourslash(t, nil /*capabilities*/, content)
+	defer done()
+	f.VerifyCompletions(t, []string{"1", "2"}, &fourslash.CompletionsExpectedList{
+		IsIncomplete: false,
+		ItemDefaults: &fourslash.CompletionsExpectedItemDefaults{
+			CommitCharacters: &DefaultCommitCharacters,
+			EditRange:        Ignored,
+		},
+		Items: &fourslash.CompletionsExpectedItems{
+			Includes: []fourslash.CompletionsExpectedItem{
+				"UserTuple",
+			},
+			Excludes: []string{
+				"User",
+			},
+		},
+	})
+
+	// After `typeof` in a tuple type we are back in a value location, so type-only symbols shouldn't be offered.
+	f.VerifyCompletions(t, "3", &fourslash.CompletionsExpectedList{
+		IsIncomplete: false,
+		ItemDefaults: &fourslash.CompletionsExpectedItemDefaults{
+			CommitCharacters: &DefaultCommitCharacters,
+			EditRange:        Ignored,
+		},
+		Items: &fourslash.CompletionsExpectedItems{
+			Includes: []fourslash.CompletionsExpectedItem{
+				"User",
+			},
+			Excludes: []string{
+				"UserTuple",
+			},
+		},
+	})
+}

tsc/internal/ls/completions.go

@@ -3361,6 +3361,8 @@ func isContextTokenTypeLocation(contextToken *ast.Node) bool {
 			return parentKind == ast.KindTypeParameter
 		case ast.KindSatisfiesKeyword:
 			return parentKind == ast.KindSatisfiesExpression
+		case ast.KindOpenBracketToken, ast.KindCommaToken:
+			return parentKind == ast.KindTupleType
 		}
 	}
 	return false