Skip to content

Reject exports from global augmentations - #64162

Draft
Daniel Rosenwasser (DanielRosenwasser) with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-global-augmentation-export
Draft

Reject exports from global augmentations#64162
Daniel Rosenwasser (DanielRosenwasser) with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-global-augmentation-export

Conversation

Copilot AI commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

export { XYZ } incorrectly accepted bindings declared in a declare global augmentation.

Changes

  • Treat global-augmentation module blocks as non-local export sources.
  • Add regression coverage for:
declare global {
    var XYZ: number;
}

export { XYZ }; // TS2661

@typescript-automation typescript-automation Bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 4, 2026
Copilot AI linked an issue Sep 4, 2026 that may be closed by this pull request
No error when exporting from global augmentations #64152
Open
Copilot AI and others added 2 commits September 4, 2026 00:55
@DanielRosenwasser
Reject exports from global augmentations
67aea51 
Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>
@DanielRosenwasser
Simplify global export validation
d6c2b0f 
Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issue with exporting from global augmentations Reject exports from global augmentations Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Awaiting requested review from DanielRosenwasser
Copilot code review Copilot
Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser)

Copilot code review Copilot

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No error when exporting from global augmentations

2 participants

@DanielRosenwasser