Preserve < in getChildren() when type arguments begin with < - #64169
Open
Mateusz Burzyński (Andarist) wants to merge 3 commits into
Open
Preserve < in getChildren() when type arguments begin with <#64169Mateusz Burzyński (Andarist) wants to merge 3 commits into
< in getChildren() when type arguments begin with <#64169Mateusz Burzyński (Andarist) wants to merge 3 commits into
Conversation
typescript-automation
Bot
added
For Uncommitted Bug
Copilot started reviewing on behalf of
Mateusz Burzyński (Andarist)
September 4, 2026 14:28
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The targeted scanner correction matches parser behavior and is covered by focused regression tests.
Pull request overview
Fixes getChildren() dropping an opening < when adjacent type arguments begin with <.
Changes:
- Rescans boundary-crossing
<<tokens as<. - Adds regression coverage for type references, calls, trivia, and shift expressions.
File summaries
| File | Description |
|---|---|
packages/typescript/src/ast/astnav.ts |
Preserves split less-than tokens during child synthesis. |
packages/typescript/test/sync/ast.test.ts |
Tests affected forms and guards ordinary shifts. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
typescript-automation
Bot
added
For Backlog Bug
| const tokenEnd = scanner.getTokenEnd(); | ||
| let token = scanner.getToken(); | ||
| let tokenEnd = scanner.getTokenEnd(); | ||
| if (token === SyntaxKind.LessThanLessThanToken && scanner.getTokenStart() < end && tokenEnd > end) { |
There was a problem hiding this comment.
Should a <<=, even if it's syntactically invalid, also needs to be accounted for?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #64168