Emit explicit telemetry when workload execution is canceled due to experiment timeout#697
Merged
nchapagain001 merged 9 commits intomainfrom Apr 28, 2026
Merged
Conversation
…imeout
Add warning-level telemetry events in two key locations:
1. ProfileExecutor.ExperimentTimeoutReached - logged when the experiment
timeout is reached, before canceling in-progress workloads
2. {TypeName}.ExecutionCancelled - logged per-component when an
OperationCanceledException is caught due to cancellation token
Both events include a structured 'terminationReason' field set to
'ExperimentTimeout' and a descriptive message to help users and
dashboards distinguish timeout-induced cancellations from real failures.
Agent-Logs-Url: https://github.com/microsoft/VirtualClient/sessions/ed26e102-6dfe-4c37-ab5f-c52008932555
Co-authored-by: nchapagain001 <165215502+nchapagain001@users.noreply.github.com>
Address code review feedback: the component-level cancellation telemetry now uses 'Cancellation' as the terminationReason since cancellation could be from timeout, manual cancellation, or reboot request. The more specific 'ExperimentTimeout' terminationReason is kept in ProfileExecutor where we know the exact cause. Agent-Logs-Url: https://github.com/microsoft/VirtualClient/sessions/ed26e102-6dfe-4c37-ab5f-c52008932555 Co-authored-by: nchapagain001 <165215502+nchapagain001@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix workload cancellation telemetry for experiment timeouts
Emit explicit telemetry when workload execution is canceled due to experiment timeout
Apr 24, 2026
- Component-level: emit crisp {TypeName}.ExecutionCancelled with
executionCancelled=true context (no assumption about cause)
- ProfileExecutor-level: emit ExperimentTimeoutReached with timeout
duration and timestamp (specific cause is known here)
- Remove wordy messages and redundant terminationReason fields
Agent-Logs-Url: https://github.com/microsoft/VirtualClient/sessions/1047bfc3-e0ae-4aca-b56f-ef3726de1a9b
Co-authored-by: nchapagain001 <165215502+nchapagain001@users.noreply.github.com>
…ntext Agent-Logs-Url: https://github.com/microsoft/VirtualClient/sessions/1047bfc3-e0ae-4aca-b56f-ef3726de1a9b Co-authored-by: nchapagain001 <165215502+nchapagain001@users.noreply.github.com>
nchapagain001
approved these changes
Apr 24, 2026
…on in test Agent-Logs-Url: https://github.com/microsoft/VirtualClient/sessions/1047bfc3-e0ae-4aca-b56f-ef3726de1a9b Co-authored-by: nchapagain001 <165215502+nchapagain001@users.noreply.github.com>
RakeshwarK
approved these changes
Apr 24, 2026
RakeshwarK
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProfileExecutor.ExecuteAsync()when the experiment times out — emitsProfileExecutor.ExperimentTimeoutReachedwith timeout duration and timestampVirtualClientComponent.ExecuteAsync()when execution is cancelled — emits{TypeName}.ExecutionCancelledwithexecutionCancelled=true