Refactor SaveImageImpl and ExportContainerImpl to eliminate code duplication #14130
+67
−67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Addresses code review feedback from #14121 requesting extraction of ~80% duplicated code between
SaveImageImplandExportContainerImplinto a shared helper function.PR Checklist
Detailed Description of the Pull Request / Additional comments
Extracted common logic into
HandleImageLikeOperationhelperm_dockerClientvalidation already performed by callersBefore:
After:
Net change: -1 LOC (67 removed, 66 added) with improved maintainability.
Validation Steps Performed
This PR targets the base branch of #14121 (not main). Validation will occur when #14121 is built and tested on Windows with Visual Studio.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.