Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 30, 2026

Summary of the Pull Request

Addresses code review feedback from #14121 regarding inconsistent parameter annotation spacing in the IDL interface definitions.

PR Checklist

  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Standardized parameter annotations in SaveImage and ExportContainer methods to match the file's convention:

  • Removed spaces inside brackets: [in, unique] not [ in, unique ]
  • Added spaces after commas: [in, out, unique] not [in,out,unique]
  • Fixed pointer spacing: Type* not Type *

Before:

HRESULT SaveImage([in] ULONG OutputHandle, [in] LPCSTR ImageNameOrID, [ in, unique ] IProgressCallback * ProgressCallback, [in, out, unique] WSLA_ERROR_INFO * ErrorInfo);
HRESULT ExportContainer([in] ULONG OutputHandle, [in] LPCSTR ContainerID, [ in, unique ] IProgressCallback * ProgressCallback, [in,out,unique] WSLA_ERROR_INFO * ErrorInfo);

After:

HRESULT SaveImage([in] ULONG OutputHandle, [in] LPCSTR ImageNameOrID, [in, unique] IProgressCallback* ProgressCallback, [in, out, unique] WSLA_ERROR_INFO* ErrorInfo);
HRESULT ExportContainer([in] ULONG OutputHandle, [in] LPCSTR ContainerID, [in, unique] IProgressCallback* ProgressCallback, [in, out, unique] WSLA_ERROR_INFO* ErrorInfo);

Validation Steps Performed

Verified spacing matches existing conventions used throughout wslaservice.idl (e.g., line 345).


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: ptrivedi <1638019+ptrivedi@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on image save and export container implementation Standardize parameter annotation spacing in wslaservice.idl Jan 30, 2026
Copilot AI requested a review from ptrivedi January 30, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants