Redesign Accept() logic to differenciate between cancellation and errors #14139
+153
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OneBlue
commented
Jan 31, 2026
|
|
||
| void wsl::windows::common::socket::Accept( | ||
| _In_ SOCKET ListenSocket, _In_ SOCKET Socket, _In_ int Timeout, _In_opt_ HANDLE ExitHandle, _In_ const std::source_location& Location) | ||
| bool wsl::windows::common::socket::CancellableAccept( |
Collaborator
Author
There was a problem hiding this comment.
@benhillis: Let me know what you think of this.
The idea is to allow the caller to differentiate between: "Something went wrong", and "the Accept() was cancelled".
This will be good because we have a tendency to log a bunch of errors when the VM terminates because all the pending accept() are cancelled.
If you're OK with this approach, I'll bring the change to master first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed