[dotnet-code] Extract skill deduplication helper

[michelle-clayton-work]

This pull request refactors the skill deduplication logic in provider.go to improve code organization and reusability. The deduplication code is extracted into a new helper function, making the main function cleaner and separating concerns.

Code organization and refactoring:

• Extracted the skill deduplication logic from loadSkills into a new helper function deduplicateSkillsByName, improving readability and reusability. (agent/skills/provider.go, agent/skills/provider.goL311-R326)
• Updated the deduplication process to use the new helper function, passing in the logger as a parameter instead of referencing it directly. (agent/skills/provider.go, agent/skills/provider.goL311-R326)

[Copilot]

Pull request overview

This PR refactors the skills provider to extract the skill name deduplication logic into a dedicated helper function, keeping the existing behavior while improving local readability and reuse within the skills package.

Changes:

• Extracted source-skill deduplication logic into deduplicateSkillsByName.
• Updated loadSkills to delegate deduplication and return the deduplicated slice.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Cross-Repo API Consistency Review

Result: ✅ No parity issues found — change is Go-internal only

This PR extracts inline skill deduplication logic from the unexported loadSkills method into a new unexported helper function deduplicateSkillsByName. The refactor:

• Introduces no new exported identifiers
• Changes no public types, options, or observable runtime behavior
• Preserves identical deduplication semantics (case-insensitive name comparison, first-occurrence wins, slog.Warn on duplicate)

This change is out of scope for cross-repo parity review. No comparison against the upstream Python or .NET implementations is needed.

Generated by Go API Consistency Review Agent for issue #351 · 38 AIC · ⌖ 12.8 AIC · ⊞ 28.4K · ◷