Skip to content

[dotnet-code] Consolidate A2A response update creation #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gdams merged 2 commits into from
Jun 30, 2026
Merged

[dotnet-code] Consolidate A2A response update creation #390

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bec52f1
Consolidate A2A response update creation
github-actions[bot] Jun 24, 2026
46e2997
Merge branch 'main' into dotnet-code-a2a-response-update-helper-67944…
michelle-clayton-work Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 21 additions & 36 deletions agent/provider/a2aagent/a2a.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,15 +194,8 @@ func sendMsg(session *agent.Session, seq iter.Seq2[a2a.Event, error], yield func
}
}
}
if !yield(&agent.ResponseUpdate{
RawRepresentation: e,
AdditionalProperties: e.Metadata,
MessageID: messageID,
ResponseID: string(e.TaskID),
Role: message.RoleAssistant,
Contents: contents,
CreatedAt: time.Now(),
}, nil) {
update := newResponseUpdate(e, e.Metadata, string(e.TaskID), messageID, message.RoleAssistant, contents, time.Now())
if !yield(update, nil) {
return
}
case *a2a.TaskArtifactUpdateEvent:
Expand All @@ -211,15 +204,8 @@ func sendMsg(session *agent.Session, seq iter.Seq2[a2a.Event, error], yield func
yield(nil, err)
return
}
if !yield(&agent.ResponseUpdate{
RawRepresentation: e,
AdditionalProperties: e.Metadata,
MessageID: string(e.Artifact.ID),
ResponseID: string(e.TaskID),
Contents: contents,
Role: message.RoleAssistant,
CreatedAt: time.Now(),
}, nil) {
update := newResponseUpdate(e, e.Metadata, string(e.TaskID), string(e.Artifact.ID), message.RoleAssistant, contents, time.Now())
if !yield(update, nil) {
return
}
case *a2a.Message:
Expand All @@ -232,15 +218,8 @@ func sendMsg(session *agent.Session, seq iter.Seq2[a2a.Event, error], yield func
if e.Role == a2a.MessageRoleAgent {
role = message.RoleAssistant
}
if !yield(&agent.ResponseUpdate{
RawRepresentation: e,
AdditionalProperties: e.Metadata,
MessageID: e.ID,
ResponseID: e.ID,
Role: role,
Contents: contents,
CreatedAt: time.Now(),
}, nil) {
update := newResponseUpdate(e, e.Metadata, e.ID, e.ID, role, contents, time.Now())
if !yield(update, nil) {
return
}
default:
Expand All @@ -250,6 +229,18 @@ func sendMsg(session *agent.Session, seq iter.Seq2[a2a.Event, error], yield func
}
}

func newResponseUpdate(raw any, additionalProperties map[string]any, responseID, messageID string, role message.Role, contents message.Contents, createdAt time.Time) *agent.ResponseUpdate {
return &agent.ResponseUpdate{
RawRepresentation: raw,
AdditionalProperties: additionalProperties,
ResponseID: responseID,
MessageID: messageID,
Role: role,
Contents: contents,
CreatedAt: createdAt,
}
}

func yieldTask(yield func(*agent.ResponseUpdate, error) bool, task *a2a.Task) bool {
now := time.Now()
var continuationToken string
Expand All @@ -271,15 +262,9 @@ func yieldTask(yield func(*agent.ResponseUpdate, error) bool, task *a2a.Task) bo
}
}

return yield(&agent.ResponseUpdate{
RawRepresentation: task,
AdditionalProperties: task.Metadata,
ResponseID: string(task.ID),
Contents: contents,
ContinuationToken: continuationToken,
Role: message.RoleAssistant,
CreatedAt: timestamp,
}, nil)
update := newResponseUpdate(task, task.Metadata, string(task.ID), "", message.RoleAssistant, contents, timestamp)
update.ContinuationToken = continuationToken
return yield(update, nil)
}

func updateSessionContextID(session *agent.Session, contextID, taskID string, taskState a2a.TaskState) error {
Expand Down
Loading