[dotnet-code] Consolidate skill resource lookup internals

[michelle-clayton-work]

This pull request refactors the handling of providedSkill in agent/skills/provider.go to improve code reuse and encapsulation. The main change is the introduction of helper methods and a constructor for providedSkill, which centralizes and simplifies resource and script lookups throughout the codebase.

Refactoring and Encapsulation Improvements:

• Added a newProvidedSkill constructor to encapsulate the creation of resource and script maps for a Skill.
• Introduced lookupResource and lookupScript methods on providedSkill to provide a consistent and encapsulated way to retrieve resources and scripts by name.

Code Simplification:

• Updated the indexSkills function to use the new newProvidedSkill constructor, reducing code duplication.
• Refactored readSkillResource and runSkillScript to use the new lookupResource and lookupScript methods, improving readability and maintainability. [1] [2]

• [dotnet-code] Consolidate skill resource lookup internals #382

[Copilot]

Pull request overview

This PR refactors agent/skills/provider.go to centralize how a providedSkill indexes and looks up resources/scripts, improving reuse and keeping lookup behavior encapsulated within the provider internals (no intended public API/behavior changes).

Changes:

• Added newProvidedSkill to build the per-skill resources/scripts lookup maps in one place.
• Added providedSkill.lookupResource / providedSkill.lookupScript helpers and updated call sites to use them.
• Simplified indexSkills by delegating construction to the new constructor.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[michelle-clayton-work]

@copilot address PR feedback

[Copilot]

@copilot address PR feedback

Done — renamed the receiver from skill to ps in both lookupResource and lookupScript methods on providedSkill (commit fe8a6d4's follow-up).

[github-actions]

API Consistency Review — No Issues Found

This PR only modifies unexported (internal) identifiers in agent/skills/provider.go:

• newProvidedSkill — unexported constructor
• lookupResource / lookupScript — methods on the unexported providedSkill type

All changes are purely internal refactoring with no impact on exported Go APIs or observable user-visible behavior. There are no new public contracts, no changed defaults, and no behavioral divergence to compare against the upstream .NET or Python implementations.

Result: Out of scope for cross-repo parity review. No consistency issues identified.

Generated by Go API Consistency Review Agent for #397 · 29.8 AIC · ⌖ 12.5 AIC · ⊞ 28.7K · ◷