Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions agent/compaction/compaction_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,50 @@ func TestMessageIndex_GroupsToolCallsAtomically(t *testing.T) {
}
}

func TestMessageIndex_SummaryPropertyValueParsing(t *testing.T) {
rawFalse := json.RawMessage(`false`)
rawTrue := json.RawMessage(`true`)
tests := []struct {
name string
value any
expected compaction.GroupKind
}{
{name: "missing", expected: compaction.GroupKindAssistantText},
{name: "bool false", value: false, expected: compaction.GroupKindAssistantText},
{name: "raw false", value: json.RawMessage(`false`), expected: compaction.GroupKindAssistantText},
{name: "raw null", value: json.RawMessage(`null`), expected: compaction.GroupKindAssistantText},
{name: "raw string", value: json.RawMessage(`"Unexpected string"`), expected: compaction.GroupKindAssistantText},
{name: "bool true", value: true, expected: compaction.GroupKindSummary},
{name: "raw true", value: json.RawMessage(`true`), expected: compaction.GroupKindSummary},
{name: "ptr raw nil", value: (*json.RawMessage)(nil), expected: compaction.GroupKindAssistantText},
{name: "ptr raw false", value: &rawFalse, expected: compaction.GroupKindAssistantText},
{name: "ptr raw true", value: &rawTrue, expected: compaction.GroupKindSummary},
{name: "bytes false", value: []byte(`false`), expected: compaction.GroupKindAssistantText},
{name: "bytes null", value: []byte(`null`), expected: compaction.GroupKindAssistantText},
{name: "bytes true", value: []byte(`true`), expected: compaction.GroupKindSummary},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
msg := textMessage(message.RoleAssistant, "Hello")
if tt.name != "missing" {
msg.AdditionalProperties = map[string]any{
"_is_summary": tt.value,
}
}

index := compaction.CreateMessageIndex([]*message.Message{msg}, nil)

if len(index.Groups) != 1 {
t.Fatalf("expected one group, got %d", len(index.Groups))
}
if got := index.Groups[0].Kind; got != tt.expected {
t.Fatalf("group kind = %v, want %v", got, tt.expected)
}
})
}
}

func TestTruncationStrategy_ExcludesOldestGroups(t *testing.T) {
index := compaction.CreateMessageIndex(turnMessages(3), nil)
strategy := &compaction.TruncationStrategy{
Expand Down
23 changes: 20 additions & 3 deletions agent/compaction/index.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
package compaction

import (
"encoding/json"
"fmt"
"slices"

Expand Down Expand Up @@ -421,8 +422,24 @@ func isSummaryMessage(msg *message.Message) bool {
if !ok {
return false
}
if boolValue, ok := value.(bool); ok {
return boolValue
switch typed := value.(type) {
case bool:
return typed
case json.RawMessage:
return rawSummaryMessageValue(typed)
case *json.RawMessage:
return typed != nil && rawSummaryMessageValue(*typed)
case []byte:
return rawSummaryMessageValue(typed)
default:
return false
}
}

func rawSummaryMessageValue(value []byte) bool {
var boolValue bool
if err := json.Unmarshal(value, &boolValue); err != nil {
return false
}
return false
return boolValue
}