Skip to content

Conversation

@ultmaster
Copy link
Contributor

patches #371

Copilot AI review requested due to automatic review settings December 6, 2025 05:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an interactive play function to the SequenceIdSortTest story to verify that the TracesTable correctly sorts data by sequence ID when clicking the sequence header.

  • Adds testing library imports (waitFor, within, userEvent)
  • Implements a play function that clicks the sequence header and verifies the sorting result

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

if (!firstRow) {
throw new Error('Expected at least one data row after sorting by sequence ID');
}
within(firstRow).getByText('task_sequence_14');
Copy link

Copilot AI Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is checking for the wrong task name after sorting. When clicking the sequence header once, it will sort in ascending order (first click on an unsorted column defaults to ascending). The sequence IDs in the test data are: 2, 10, 3, 11, 9, 12, 4, 6, 7, 13, 14. After sorting by sequence ID in ascending order, the first row should contain task_sequence_2, not task_sequence_14. Change this to:

within(firstRow).getByText('task_sequence_2');
Suggested change
within(firstRow).getByText('task_sequence_14');
within(firstRow).getByText('task_sequence_2');

Copilot uses AI. Check for mistakes.
@ultmaster ultmaster merged commit ad89e17 into main Dec 6, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants