feat: support package namespaces for skills#1028
Open
shreejaykurhade wants to merge 7 commits intomicrosoft:mainfrom
Open
feat: support package namespaces for skills#1028shreejaykurhade wants to merge 7 commits intomicrosoft:mainfrom
shreejaykurhade wants to merge 7 commits intomicrosoft:mainfrom
Conversation
Add an optional namespace field to apm.yml, deploy package-owned skills and promoted sub-skills under skills/<namespace>/<skill-name>, and persist the namespace in apm.lock.yaml. Also document the namespace schema and add coverage for validation, namespaced deployment, lockfile round-tripping, and lockfile assembly.
…ge-namespaces # Conflicts: # src/apm_cli/install/phases/lockfile.py # src/apm_cli/integration/skill_integrator.py # src/apm_cli/models/apm_package.py
shreejaykurhade
requested review from
danielmeppiel and
sergio-sisternes-epam
as code owners
Contributor
Author
|
@danielmeppiel @sergio-sisternes-epam please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional namespace field to
apm.yml, deploy package-owned skills and promoted sub-skills underskills/<namespace>/<skill-name>, and persist the namespace inapm.lock.yaml.Also document the namespace schema and add coverage for validation, namespaced deployment, lockfile round-tripping, and lockfile assembly.
Description
This PR implements opt-in package namespaces for skill deployment.
Today, installed skills from project packages, direct dependencies, and transitive dependencies are flattened into the same
skills/directory. That makes it harder to identify where a skill came from and easier to accidentally edit dependency-owned skills while working in a project.With this change, package authors can declare a safe single-segment
namespaceinapm.yml. When present, APM deploys native package skills and promoted.apm/skills/sub-skills under:Packages without namespace keep the existing flat layout, so current packages remain backward compatible.
Fixes #739
Type of change
Testing
Local checks run:
python -m pytest tests\test_apm_package_models.py
python -m pytest tests\unit\integration\test_skill_integrator.py tests\test_lockfile.py
python -m pytest tests\unit\test_drift_detection.py tests\unit\test_install_update.py -k "build_download_ref or drift"
python -m pytest tests\unit\test_artifactory_support.py -k "download_ref or registry_prefix"