Skip to content

docs(compile): clarify target routing docstring #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WilliamK112 wants to merge 1 commit into from
+7 −3
Closed

docs(compile): clarify target routing docstring #931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/apm_cli/commands/compile/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,14 @@ def _get_validation_suggestion(error_msg):


def _resolve_compile_target(target):
"""Map CLI target input to compiler-understood target string.
"""Map CLI target input to a compiler/detection target string.

The compiler only understands ``"vscode"``, ``"claude"``, and ``"all"``.
Multi-target lists are mapped to the narrowest equivalent.
Single targets are passed through unchanged. Multi-target lists are mapped
to the narrowest equivalent routing target:

- any AGENTS-family target only -> ``"vscode"``
- ``"claude"`` only -> ``"claude"``
- AGENTS-family target(s) plus ``"claude"`` -> ``"all"``
Comment on lines +169 to +174
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The term "AGENTS-family target" is introduced here but not defined anywhere else in this module, which makes the mapping rules ambiguous (especially since the list case treats cursor/opencode/codex as part of that family). Consider explicitly listing the values included in this family (e.g., copilot/vscode/agents/cursor/opencode/codex) or rephrasing the bullets in terms of "any non-claude targets" so readers can predict how a given multi-target list will be routed.

Copilot uses AI. Check for mistakes.

Args:
target: A single target string, a list of target strings, or ``None``.
Expand Down
Loading