Drop local WALinuxAgent spec, use upstream via walinuxagent-acl-config#30
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the repository-local RPM spec (and associated patches/signatures) for WALinuxAgent and switches the RPM image build mapping to rely on the upstream packaging path via walinuxagent-acl-config.
Changes:
- Updated the RPM package catalog mapping for
app-emulation/wa-linux-agentto installwalinuxagent-acl-config(which is intended to pull in WALinuxAgent as a dependency). - Removed the local
acl/SPECS/WALinuxAgent/*packaging assets (spec, patches, signatures, and helper files). - Removed
WALinuxAgentfrom the ACL “locally-built RPMs” list (acl/packages.yaml).
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| build_library/rpm/package_catalog.yaml | Switches the RPM-mode dependency mapping for wa-linux-agent to walinuxagent-acl-config. |
| acl/SPECS/WALinuxAgent/WALinuxAgent.spec | Removes the local WALinuxAgent spec (moving responsibility to upstream packaging). |
| acl/SPECS/WALinuxAgent/WALinuxAgent.signatures.json | Removes signature hashes for the local WALinuxAgent source/artifacts. |
| acl/SPECS/WALinuxAgent/update-setup.patch | Removes a local patch previously applied to WALinuxAgent packaging. |
| acl/SPECS/WALinuxAgent/module-setup.sh | Removes the dracut module script previously shipped by the local WALinuxAgent RPM. |
| acl/SPECS/WALinuxAgent/fix-argument-to-goalstate.patch | Removes a local WALinuxAgent patch file. |
| acl/SPECS/WALinuxAgent/ephemeral-disk-warning.service | Removes locally-packaged ephemeral disk warning systemd unit. |
| acl/SPECS/WALinuxAgent/ephemeral-disk-warning.conf | Removes locally-packaged ephemeral disk warning config. |
| acl/SPECS/WALinuxAgent/ephemeral-disk-warning | Removes locally-packaged ephemeral disk warning script. |
| acl/SPECS/WALinuxAgent/acl-support.patch | Removes the large ACL support patch previously applied via the local spec. |
| acl/SPECS/WALinuxAgent/0002-fix-bump-version-to-2.11.8.8.patch | Removes a local version-bump patch file. |
| acl/SPECS/WALinuxAgent/0001-add-azurelinux-support.patch | Removes a local Azure Linux support patch file. |
| acl/packages.yaml | Drops WALinuxAgent from the set of ACL-specific locally built/patched RPMs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jiria
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop local WALinuxAgent spec, use upstream via walinuxagent-acl-config
Change Log
Type of Change
Does this affect the image build?
Associated Issues
https://dev.azure.com/mariner-org/ACL/_workitems/edit/22113/
Test Methodology
Merge Checklist
All applicable boxes should be checked before merging