Skip to content

Drop local WALinuxAgent spec, use upstream via walinuxagent-acl-config#30

Merged
mayankfz merged 1 commit into
aclmainfrom
mayansingh/waagent_acl_conf
Jul 21, 2026
Merged

Drop local WALinuxAgent spec, use upstream via walinuxagent-acl-config#30
mayankfz merged 1 commit into
aclmainfrom
mayansingh/waagent_acl_conf

Conversation

@mayankfz

@mayankfz mayankfz commented Jul 17, 2026

Copy link
Copy Markdown

Summary

Drop local WALinuxAgent spec, use upstream via walinuxagent-acl-config

Change Log

  • Drop local WALinuxAgent spec, use upstream via walinuxagent-acl-config

Type of Change

  • Image build change (base image, sysexts, OEM images)
  • Package/SPEC update
  • CI/automation change
  • SDK/toolchain update
  • Configuration change
  • Documentation update
  • Bug fix

Does this affect the image build?

  • Yes
  • No

Associated Issues

https://dev.azure.com/mariner-org/ACL/_workitems/edit/22113/

Test Methodology

Merge Checklist

All applicable boxes should be checked before merging

  • Image builds successfully with this change (or image build is not affected)
  • Any updated packages/SPECs build successfully
  • Relevant kola tests pass
  • All package sources are available
  • Source files have up-to-date hashes/manifests
  • Documentation has been updated to match any changes
  • Ready to merge

@mayankfz
mayankfz marked this pull request as ready for review July 20, 2026 08:57
@mayankfz
mayankfz requested a review from a team as a code owner July 20, 2026 08:57
Copilot AI review requested due to automatic review settings July 20, 2026 08:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the repository-local RPM spec (and associated patches/signatures) for WALinuxAgent and switches the RPM image build mapping to rely on the upstream packaging path via walinuxagent-acl-config.

Changes:

  • Updated the RPM package catalog mapping for app-emulation/wa-linux-agent to install walinuxagent-acl-config (which is intended to pull in WALinuxAgent as a dependency).
  • Removed the local acl/SPECS/WALinuxAgent/* packaging assets (spec, patches, signatures, and helper files).
  • Removed WALinuxAgent from the ACL “locally-built RPMs” list (acl/packages.yaml).

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
build_library/rpm/package_catalog.yaml Switches the RPM-mode dependency mapping for wa-linux-agent to walinuxagent-acl-config.
acl/SPECS/WALinuxAgent/WALinuxAgent.spec Removes the local WALinuxAgent spec (moving responsibility to upstream packaging).
acl/SPECS/WALinuxAgent/WALinuxAgent.signatures.json Removes signature hashes for the local WALinuxAgent source/artifacts.
acl/SPECS/WALinuxAgent/update-setup.patch Removes a local patch previously applied to WALinuxAgent packaging.
acl/SPECS/WALinuxAgent/module-setup.sh Removes the dracut module script previously shipped by the local WALinuxAgent RPM.
acl/SPECS/WALinuxAgent/fix-argument-to-goalstate.patch Removes a local WALinuxAgent patch file.
acl/SPECS/WALinuxAgent/ephemeral-disk-warning.service Removes locally-packaged ephemeral disk warning systemd unit.
acl/SPECS/WALinuxAgent/ephemeral-disk-warning.conf Removes locally-packaged ephemeral disk warning config.
acl/SPECS/WALinuxAgent/ephemeral-disk-warning Removes locally-packaged ephemeral disk warning script.
acl/SPECS/WALinuxAgent/acl-support.patch Removes the large ACL support patch previously applied via the local spec.
acl/SPECS/WALinuxAgent/0002-fix-bump-version-to-2.11.8.8.patch Removes a local version-bump patch file.
acl/SPECS/WALinuxAgent/0001-add-azurelinux-support.patch Removes a local Azure Linux support patch file.
acl/packages.yaml Drops WALinuxAgent from the set of ACL-specific locally built/patched RPMs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mayankfz
mayankfz merged commit f931ede into aclmain Jul 21, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants