Skip to content

feat(package list): add --synthesize-debug-packages to package list#108

Merged
reubeno merged 5 commits intomicrosoft:mainfrom
reubeno:synthesize-debug-packages
Apr 21, 2026
Merged

feat(package list): add --synthesize-debug-packages to package list#108
reubeno merged 5 commits intomicrosoft:mainfrom
reubeno:synthesize-debug-packages

Conversation

@reubeno
Copy link
Copy Markdown
Member

@reubeno reubeno commented Apr 21, 2026

Augments azldev package list with synthetic -debuginfo packages (one per reported package, with -debuginfo modifier of the publish channel) and -debugsource packages.

This is a short-term approach until we're able to properly merge changes that shift us over to an inheritance-driven declaration for where source packages, debuginfo packages, etc. should go for a given component (i.e. #107).

Copilot AI review requested due to automatic review settings April 21, 2026 02:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an opt-in azldev package list mode to emit additional “synthetic” debug-related packages alongside the normally-resolved package list, primarily to support short-term downstream routing needs until component-level publish-channel inheritance lands (ref #107).

Changes:

  • Add --synthesize-debug-packages flag and option plumbing for azldev package list.
  • Implement synthesis of *-debuginfo (per listed package) and *-debugsource (per component) entries.
  • Add unit tests and regenerate CLI reference docs for the new flag.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
internal/app/azldev/cmds/pkg/list.go Adds flag/option and implements synthesizeDebugPackages to augment list results.
internal/app/azldev/cmds/pkg/list_test.go Adds tests covering basic synthesis behavior and collision-skipping behavior.
docs/user/reference/cli/azldev_package_list.md Updates CLI docs to include the new --synthesize-debug-packages option.

Comment thread internal/app/azldev/cmds/pkg/list.go
Comment thread internal/app/azldev/cmds/pkg/list.go Outdated
Augments 'azldev package list' with synthetic '-debuginfo' packages (one per
reported package, sharing the original publish channel) and '-debugsource'
packages (one per component, resolved with no per-package override so they
fall back to the configured default publishing channel).

This is a short-term approach until we're able to properly merge changes
that shift us over to an inheritance-driven declaration for where source
packages, debuginfo packages, etc. should go for a given component.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@reubeno reubeno force-pushed the synthesize-debug-packages branch from c53827a to 89e2a20 Compare April 21, 2026 03:24
reubeno and others added 2 commits April 21, 2026 00:59
- Skip synthesis for source names already ending in '-debuginfo' or
  '-debugsource' to avoid recursive doubled suffixes (e.g. 'foo-debuginfo-
  debuginfo') when those packages are already in the listed set.
- Restore '-debugsource' channel resolution via ResolvePackageConfig so the
  result carries an honest channel value (component default → project default)
  rather than an implicit empty 'consumer applies default' contract.
- Emit an slog.Warn that the flag is transitional and may change.
- Document that '-debugsource' is emitted for every component regardless of
  the requested package set, since most listed packages come from groups with
  no component association.
- Tests: add assertions that doubled-suffix names are NOT synthesized; add a
  '-p' + flag test covering the headline CLI path.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Synthesized debug packages now publish to a parallel channel: any resolved,
non-empty, non-'none' channel is suffixed with '-debuginfo' (channels that
already end in '-debuginfo' are left as-is). Empty and 'none' channels pass
through unchanged so 'do not publish' and 'use default' semantics are
preserved.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 21, 2026 08:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Comment thread internal/app/azldev/cmds/pkg/list.go Outdated
Comment thread internal/app/azldev/cmds/pkg/list.go Outdated
Comment thread internal/app/azldev/cmds/pkg/list.go Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 21, 2026 08:47
@reubeno reubeno marked this pull request as ready for review April 21, 2026 08:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Comment thread internal/app/azldev/cmds/pkg/list.go Outdated
Comment thread internal/app/azldev/cmds/pkg/list.go Outdated
Comment thread internal/app/azldev/cmds/pkg/list.go Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 21, 2026 14:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comment thread internal/app/azldev/cmds/pkg/list.go
Comment thread internal/app/azldev/cmds/pkg/list.go
Copy link
Copy Markdown
Contributor

@binujp binujp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@reubeno reubeno merged commit 236864b into microsoft:main Apr 21, 2026
19 checks passed
@reubeno reubeno deleted the synthesize-debug-packages branch April 21, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants