fix: Parse URL sources that use the rename '#' tag#118
Merged
dmcilvaney merged 2 commits intomicrosoft:mainfrom Apr 24, 2026
Merged
fix: Parse URL sources that use the rename '#' tag#118dmcilvaney merged 2 commits intomicrosoft:mainfrom
dmcilvaney merged 2 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves RPM spectool output parsing to correctly handle the RPM “rename via URL fragment” convention (e.g., #/local-name), ensuring derived filenames match what RPM tooling expects.
Changes:
- Extend URL filename extraction to prefer RPM-style fragment-based rename markers (
#/...and#./...). - Add/adjust unit tests covering fragment-rename cases in both
ParseSpectoolOutputandfilenameFromURL.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/rpm/spectool/spectool.go | Teach filenameFromURL to use RPM fragment rename conventions when present. |
| internal/rpm/spectool/spectool_test.go | Add test cases validating fragment rename extraction behavior. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jslobodzian
approved these changes
Apr 24, 2026
reubeno
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.