feat(overlays): make source optional in file-add overlays#119
Open
Kelvinoppong wants to merge 1 commit intomicrosoft:mainfrom
Open
feat(overlays): make source optional in file-add overlays#119Kelvinoppong wants to merge 1 commit intomicrosoft:mainfrom
Kelvinoppong wants to merge 1 commit intomicrosoft:mainfrom
Conversation
When the destination filename matches the source filename (the common case), users no longer need to specify both `file` and `source`. For `file-add` overlays, `source` now defaults to the value of `file` when omitted. Closes microsoft#30
Contributor
Author
|
@reubeno this PR is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sourcefield optional forfile-addoverlays.sourceis omitted, it defaults to the value offile, covering the common case where destination and source filenames match.Closes #30
Changes
internal/projectconfig/overlay.go: apply thesource-defaults-to-filelogic inWithAbsolutePaths; relaxValidate()sosourceis no longer required forfile-add; update struct tag / JSON schema description.internal/projectconfig/overlay_test.go: flip the "file-add missing source" case to expect success; addTestComponentOverlay_WithAbsolutePathscovering explicit source preserved, default-from-file, no-mutation-of-original, and non-file-addtypes untouched.docs/user/reference/config/overlays.md: document the optional field and add a shorthand example.Test plan
go test ./internal/projectconfig/...passes locallygo test ./internal/app/azldev/core/sources/...passes locallyschemas/azldev.schema.json) already reflects the new description (diff verified clean)