feat(render): Allow opt-out for file filtering#120
Merged
dmcilvaney merged 1 commit intomicrosoft:mainfrom Apr 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a per-component “escape hatch” to skip post-render file filtering when spectool can’t correctly expand Source/Patch macro paths, preventing valid files from being incorrectly removed during azldev component render.
Changes:
- Introduces
[components.<name>.render]config withskip-file-filterto disable the post-render filtering step per component. - Wires the new config into the render pipeline to conditionally bypass
removeUnreferencedFiles. - Updates component fingerprint exclusions and JSON schema to reflect the new config surface.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| schemas/azldev.schema.json | Adds schema entries for the new component render section and skip-file-filter field. |
| internal/projectconfig/render.go | Defines ComponentRenderConfig and the skip-file-filter field. |
| internal/projectconfig/fingerprint_test.go | Registers ComponentConfig.Render as excluded from fingerprinting. |
| internal/projectconfig/component.go | Adds Render ComponentRenderConfig to ComponentConfig and preserves it in WithAbsolutePaths. |
| internal/app/azldev/cmds/component/render.go | Skips post-render file filtering when Render.SkipFileFilter is set. |
reubeno
approved these changes
Apr 24, 2026
Auto-detect unexpanded RPM macros in spectool output during rendering.
When spectool cannot resolve macros in Source/Patch tags, the reported
filenames contain literal %{...} sequences that don't match real files
on disk, causing the post-render file filter to incorrectly delete them.
The renderer now checks for unexpanded macros and automatically skips
file filtering when found. A manual escape hatch is also available:
[components.<name>.render]
skip-file-filter = true
- Add findUnexpandedMacro() to detect unresolved macros in spectool output
- Add ComponentRenderConfig with SkipFileFilter field
- Wire auto-detection and manual config into finishComponentRender
- Add ComponentRenderConfig to fingerprinted structs (affects build output)
- Document render config in components.md and update JSON schema
dmcilvaney
force-pushed
the
damcilva/add_file_filter_skip
branch
from
7058cdc to
a6714d2
Compare
reubeno
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an escape hatch for rendering packages which have unparsable spec files (ie source entries use dynamic macros that can't be resolved by a basic spec parse).