docs: Add missing uki-addons output artifacts item type#615
docs: Add missing uki-addons output artifacts item type#615vinceaperri wants to merge 3 commits into
Conversation
|
|
||
| - `ukis` – UKI PE images (`vmlinuz-<version>.efi`) and their associated addon files | ||
| (`vmlinuz-<version>.efi.extra.d/vmlinuz-<version>.addon.efi`). | ||
| - `uki-addons` – UKI addon files only (`vmlinuz-<version>.addon.efi`), without |
There was a problem hiding this comment.
This was added to InjectArtifactMetadata.type. But in outputArtifacts.type, uki includes UKI addons.
There was a problem hiding this comment.
I see. It's currently a valid option the user can specify, so should it be removed from func (i OutputArtifactsItemType) IsValid(), or are there plans for it to be in user configs in the future?
There was a problem hiding this comment.
For now, it is an invalid option for .output.artifacts[].type, since specifying uki will also output UKI addons. But it should remain a valid option for inject-files.
|
|
||
| - `ukis` – UKI PE images (`vmlinuz-<version>.efi`) and their associated addon files | ||
| (`vmlinuz-<version>.efi.extra.d/vmlinuz-<version>.addon.efi`). | ||
| - `uki-addons` – UKI addon files only (`vmlinuz-<version>.addon.efi`), without |
There was a problem hiding this comment.
I think the four items that actually trigger artifact extraction are ukis, shim, systemd-boot but no block for uki-addons. There is a OutputArtifactsItemUkiAddons constant is only used as an internal metadata type tag when addon files are discovered during ukis processing.
vinceaperri
force-pushed
the
user/vinceaperri/docs-uki-addons
branch
from
1e9a07a to
a354bde
Compare
| OutputArtifactsItemDefault OutputArtifactsItemType = "" | ||
| ) | ||
|
|
||
| func (i OutputArtifactsItemType) IsValid() error { |
There was a problem hiding this comment.
Is any product code calling the OutputArtifactsItemType.IsValid() function?
| func TestOutputArtifactsItemTypeIsValidOutputItem_UkiAddons_Fail(t *testing.T) { | ||
| err := OutputArtifactsItemUkiAddons.IsValidOutputItem() | ||
| assert.Error(t, err) | ||
| assert.ErrorContains(t, err, "uki-addons are automatically included with ukis") |
There was a problem hiding this comment.
I am not seeing the uki-addons are automatically included with ukis error in the IsValidOutputItem function.
3 participants
No description provided.