Skip to content

azl4: Support distro-aware grub stub assets and multiple EFI stub dirs#732

Merged
vinceaperri merged 2 commits into
mainfrom
user/vinceaperri/multi-distro-grub
May 14, 2026
Merged

azl4: Support distro-aware grub stub assets and multiple EFI stub dirs#732
vinceaperri merged 2 commits into
mainfrom
user/vinceaperri/multi-distro-grub

Conversation

@vinceaperri
Copy link
Copy Markdown
Contributor

Plumb per-distro grub assets and EFI stub install directories through installEfiBootloader so Azure Linux 4.0 can use its own /etc/default/grub template and install stub grub.cfg files under EFI/fedora and EFI/BOOT instead of boot/grub2.

@vinceaperri vinceaperri requested a review from a team as a code owner May 8, 2026 21:21
@vinceaperri vinceaperri changed the title Support distro-aware grub stub assets and multiple EFI stub dirs azl4: Support distro-aware grub stub assets and multiple EFI stub dirs May 8, 2026
Copy link
Copy Markdown
Contributor

@liulanze liulanze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but could we add an integration test verifying the stub grub.cfg files land in the expected ESP locations for both distros? This PR introduces new install layout and adds new asset templates that we may want to have test coverage.

Comment thread toolkit/tools/internal/resources/resources.go Outdated
Copy link
Copy Markdown
Contributor

@liulanze liulanze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vinceaperri vinceaperri merged commit 609ac62 into main May 14, 2026
39 checks passed
@vinceaperri vinceaperri deleted the user/vinceaperri/multi-distro-grub branch May 14, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants