Skip to content

Build Wireshark package with Lua support#16843

Open
idryzhov wants to merge 2 commits intomicrosoft:3.0-devfrom
idryzhov:wireshark-lua
Open

Build Wireshark package with Lua support#16843
idryzhov wants to merge 2 commits intomicrosoft:3.0-devfrom
idryzhov:wireshark-lua

Conversation

@idryzhov
Copy link
Copy Markdown

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Enable Lua support in Wireshark to be able to load custom dissectors.

Change Log
  • Enable Lua support flag in Wireshark package spec
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology
  • Local build + actual validation that custom dissectors are loaded and used by tshark -X

@idryzhov idryzhov requested a review from a team as a code owner April 23, 2026 22:18
@microsoft-github-policy-service microsoft-github-policy-service Bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0 PRs Destined for 3.0 labels Apr 23, 2026
Comment thread SPECS-EXTENDED/wireshark/wireshark.spec Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to bump the release number by 1. Need to add a changelog entry explaining the change

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Copy Markdown
Author

@idryzhov idryzhov Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also had to fix link to the sources to pass the PR validation - the current link is outdated - /src only has recent versions, so we should use /src/all-versions where all versions are preserved.

@idryzhov idryzhov changed the base branch from 3.0 to 3.0-dev April 24, 2026 00:21
@idryzhov idryzhov requested a review from a team as a code owner April 24, 2026 00:21
@microsoft-github-policy-service microsoft-github-policy-service Bot added the 3.0-dev PRs Destined for AzureLinux 3.0 label Apr 24, 2026
The current link is outdated - /src only has recent versions, so we
should use /src/all-versions where all versions are preserved.
@idryzhov
Copy link
Copy Markdown
Author

@idryzhov please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@idryzhov idryzhov requested a review from jslobodzian April 24, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 3.0 PRs Destined for 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants