refactor(openssl-fips-provider): Better align with openssl's fips provider#16844
Open
corvus-callidus wants to merge 3 commits into3.0-devfrom
Open
refactor(openssl-fips-provider): Better align with openssl's fips provider#16844corvus-callidus wants to merge 3 commits into3.0-devfrom
corvus-callidus wants to merge 3 commits into3.0-devfrom
Conversation
…embedded HMAC Remove all Fedora-derived patches and build unmodified OpenSSL 3.1.2 FIPS provider. Use upstream `openssl fipsinstall` to generate config with the module integrity HMAC, replacing the embedded HMAC approach (patch 0033).
Update openssl 3.3.7 patch 0032 to load fipsmodule.cnf with [fips_sect] instead of fips_prov.cnf with [fips_prov_sect], aligning with upstream OpenSSL naming. Update openssl-fips-provider to match. Bump openssl to 3.3.7-2 and update toolkit manifests. Add openssl-fips-provider Requires on openssl >= 3.3.7-2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Simplify openssl-fips-provider by removing all Fedora-derived patches and using upstream
openssl fipsinstallto generate the FIPS module config with its integrity HMAC, replacing the embedded HMAC approach. Align both openssl (3.3.7) and openssl-fips-provider (3.1.2) to use the upstream fipsmodule.cnf / [fips_sect] naming convention instead of the custom fips_prov.cnf / [fips_prov_sect].Change Log
Does this affect the toolchain?
YES
Associated issues
Links to CVEs
Test Methodology