Minor no-op changes to vm-base kiwi definition#16878
Open
ddstreet wants to merge 2 commits intomicrosoft:tomls/base/mainfrom
Open
Minor no-op changes to vm-base kiwi definition#16878ddstreet wants to merge 2 commits intomicrosoft:tomls/base/mainfrom
ddstreet wants to merge 2 commits intomicrosoft:tomls/base/mainfrom
Conversation
The base image should not have any users created, that is handled by cloud-init (or other means). The root user will always be created in the image.
This removes the vm-base kiwi configuration that disables UEFI UKI creation, as that (i.e. disabled; don't create a UKI) is already the default action.
christopherco
approved these changes
Apr 25, 2026
Collaborator
|
Changes LGTM, but I had merged some of your other kiwi changes. Please rebase and I'll re-review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove commented-out element and unneeded dracut element. This should be a no-op, with no change to generated image.