Enable the customization of the name of DOM elements when clicked#501
Open
jonathanghm wants to merge 1 commit intomicrosoft:masterfrom
Open
Enable the customization of the name of DOM elements when clicked#501jonathanghm wants to merge 1 commit intomicrosoft:masterfrom
jonathanghm wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
YoRab
approved these changes
Oct 7, 2024
DorianGentine
approved these changes
Oct 7, 2024
legz
approved these changes
Oct 7, 2024
|
This evolution would be very useful in our context (we have buttons without text labels that Clarity can understand). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Enable the customization of the name of DOM elements when clicked.
Motivation
1. Independence from the content of the DOM element:
By using a custom attribute, the logic for event tracking is separated from the content of the element. This provides flexibility to change the content without affecting the tracking logic.
2. Avoids internationalization issues:
In multilingual applications, the text of the element may change depending on the language, which could complicate tracking. A custom attribute can provide a more stable identifier.
2. Privacy enhancement:
There may be scenarios where an element contains sensitive information, like email, name or passwords. This enhances the masking option already provided by clarity and additionally gives the analytics more context about the action.
How does it work?
By using the custom attribute "data-clarity-event" on the clickable DOM element, this will be considered as the default event name.
If the custom attribute "data-clarity-event" does not exist on the element, the current logic will be followed to obtain the name (textContent, value, or alt).